Use dotnet 8 feed. #1153
Use dotnet 8 feed. #1153
Conversation
|
Thank you for starting this effort! It looks like things are pretty clean, actually, aside from the RemovePattern codefix. Happy to take a look at that if you'd like. |
|
I'll check out the failing tests later this week. Might poke you when I'm stuck somewhere. |
|
I think I may have found a potential regression with It no longer works and I can no longer get the diagnostics when compiling with my local compiler. I've asked @edgarfgp if he could do some digging at the compiler side. |
|
Found the problem and I will fix in the compiler next week :) |
|
Great work, folks! Happy that FSAC can help detect bugs before they release:) |
|
@jwosty here's where we're talking about the regression in the nightly builds of FSAC - its to do with the 725 diagnostic in pattern matching. |
|
@edgarfgp I've updated FCS to a version that contains your latest fix. The unit tests now work as expected again! There still of course might be other things before we can take this one in. |
| @@ -11,7 +11,7 @@ let title = "Add missing '=' to type definition" | |||
|
|
|||
| /// a codefix that adds in missing '=' characters in type declarations | |||
| let fix (getFileLines: GetFileLines) = | |||
| Run.ifDiagnosticByCode (Set.ofList [ "3360" ]) (fun diagnostic codeActionParams -> | |||
| Run.ifDiagnosticByCode (Set.ofList [ "10" ]) (fun diagnostic codeActionParams -> | |||
There was a problem hiding this comment.
Context: dotnet/fsharp#15585 (comment)
3360 doesn't seem to be a related thing anymore here:
https://github.com/dotnet/fsharp/blob/109a84d633917aa6e331187fc63eb509ef1a6dc1/src/Compiler/FSComp.txt#L1596
|
Side note: this test is unreliable on my machine: The diagnostic message has a newline in there and sometimes the test fails because the message only contains the first part before the I checked the test over at FCS side: [<Fact>]
let ``Suggest namespace correction`` () =
FSharp """
open System.Text.RegularEcpressions
"""
|> typecheck
|> shouldFail
|> withSingleDiagnostic (Error 39, Line 2, Col 18, Line 2, Col 36,
("The namespace 'RegularEcpressions' is not defined. Maybe you want one of the following:" + Environment.NewLine + " RegularExpressions"))This worked as expected. EDIT: CI appears to have the same problem: |
WHAT
🤖 Generated by Copilot at ed906db
The pull request updates the FsAutoComplete project to use the latest F# compiler version and its new syntax tree representation. It modifies several modules and files that deal with code generation, syntax analysis, error detection, and completion suggestions. It also updates the
paket.dependenciesfile to use the dotnet8 feed and the latest preview ofFSharp.Compiler.Service.🤖 Generated by Copilot at ed906db
✨💥🔧
WHY
HOW
🤖 Generated by Copilot at ed906db
ParseAndCheckResults.fsfile to support the new completion suggestions feature in the F# compiler (link)WIP: not sure what CI will say. Compiled on my machine.